-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React hot loader not compatible with electron #720
Comments
The v4 will be based on a new proxy system. As soon as we will release a beta, we should test it on Electron. |
@neoziro any ETA? Can the master branch be tested? |
@okonet - I hope this weekends. |
Yes I hope too. |
Please let me know as I can help testing it. |
I tested it and it does not change the result. But I think it is related to your setup. It looks like code in I tried to pass So this issue is probably not related to React Hot Loader, and maybe even not related to Hot Module Reloading. |
Can confirm it's working with electron 1.8.2 beta! 👏 |
@okonet I still have the issue. Could you tell me what you used to test it ? Could you tell me if it is working also for you with this setup : https://github.com/rllola/hmr-example-issue ? |
@rllola your application is not wrapped with |
@neoziro Thanks ! It is working now. |
If you are reporting a bug or having an issue setting up React Hot Loader, please fill in below. For feature requests, feel free to remove this template entirely.
Description
When using react hot loader in electron, the
instanceof
seems to be broken. At least when reloading the result is difference that when running it for the first time.Expected behavior
I would expect
instanceof
to have the same result after reloading.Actual behavior
After reloading the
instanceof
operator return a different answer than the first time.Environment
React Hot Loader version:
3.1.3
Run these commands in the project folder and fill in their results:
node -v
: 7.10.1npm -v
: 5.4.2Then, specify:
Reproducible Demo
https://github.com/rllola/hmr-example-issue
The text was updated successfully, but these errors were encountered: