Refactor project #844
Refactor project #844
Conversation
gregberge
commented
Feb 6, 2018
•
gregberge
commented
- Refactor all project
- Remove Lerna
- Simplify code
Codecov Report
@@ Coverage Diff @@
## next #844 +/- ##
=========================================
- Coverage 86.21% 86.12% -0.1%
=========================================
Files 25 30 +5
Lines 573 598 +25
Branches 141 139 -2
=========================================
+ Hits 494 515 +21
- Misses 59 67 +8
+ Partials 20 16 -4
Continue to review full report at Codecov.
|
gregberge
force-pushed
the
wip-refactoring
branch
2 times, most recently
from
4513144
to
06acf6b
Compare
| "devDependencies": { | ||
| "babel-cli": "^6.7.5", | ||
| "babel-core": "^6.7.6", | ||
| "babel-eslint": "^8.2.1", | ||
| "babel-jest": "^22.1.0", | ||
| "babel-plugin-dynamic-import-node": "^1.2.0", | ||
| "babel-plugin-external-helpers": "^6.22.0", |
There was a problem hiding this comment.
I've removed this plugin from rollup config, but not from the package json.
There was a problem hiding this comment.
It has a side effect on the final bundle, causing this bug - storybookjs/storybook#1320
So, I've just removed it, and double check that bundle is ok-ish. Lets dont introduce some external stuff, the final customer should also inject in his code.
test/hot.dev.test.js
Outdated
| @@ -99,7 +99,7 @@ describe('hot (dev)', () => { | |||
| }, 1) | |||
| }) | |||
|
|
|||
| it('should trigger error in unmount in opened state', () => { | |||
| it.only('should trigger error in unmount in opened state', () => { | |||
| @@ -148,21 +148,21 @@ function inject(target, currentGeneration, injectedMembers) { | |||
| key, | |||
| `(function REACT_HOT_LOADER_SANDBOX () { | |||
| var _this = this; // common babel transpile | |||
| var _this2 = this; // common babel transpile | |||
| var _this2 = this; // common babel transpile | |||
There was a problem hiding this comment.
This is ☠️, I know that _this3 exists.
In ideal we should or inject regenerate in a constructor, to make these variables visible, or detect the error on regenerate, and ask to disable arrow function transpiling.
gregberge
force-pushed
the
wip-refactoring
branch
from
85d5c80
to
7b08d07
Compare
- Refactor all project - Remove Lerna - Simplify code
gregberge
force-pushed
the
wip-refactoring
branch
from
7b08d07
to
2ebdacd
Compare
