Improve Typescript implementation #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 284
💛 - Coveralls |
nam-hle
reviewed
Apr 20, 2021
| @@ -1,17 +1,19 @@ | |||
| { | |||
There was a problem hiding this comment.
Please help me exclude node_modules 🥰
There was a problem hiding this comment.
What do you wanna achieve? Just setting skipLibsCheck to true?
There was a problem hiding this comment.
I wanna speed up the compilation, but maybe lead to type riskies. So keep as it 😃
|
Great work, @realityking. Thanks a lot. |
|
🎉 This PR is included in version 6.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
nam-hle
pushed a commit
to nam-hle/table
that referenced
this pull request
Apr 22, 2021
* Move generated validators to src/ to simplify set-up and validate more types * Use ts-node to run tests directly of the Typescript source * Don't compile tests during build and simplify the shipped directory structure * Don't generate sourcemaps for dist builds
nam-hle
pushed a commit
to nam-hle/table
that referenced
this pull request
Apr 22, 2021
* Move generated validators to src/ to simplify set-up and validate more types * Use ts-node to run tests directly of the Typescript source * Don't compile tests during build and simplify the shipped directory structure * Don't generate sourcemaps for dist builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very cool to see #147 merged. I'd like to offer a few improvements
srcfolder underdist, keeping a flatter file structure by compiling only the tests.d.tsfilets-nodeto run tests directly of the Typescript codeIt might be easier to review this commit by commit.