Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix(abigen): clippy warnings on solidity bindings #1319

Merged
merged 1 commit into from
May 27, 2022

Conversation

clifton
Copy link
Contributor

@clifton clifton commented May 27, 2022

Motivation

disable clippy warnings for solidity contracts with non-standard names (yvVaults, console, etc)

❯ cargo check
warning: type `console` should have an upper camel case name
  --> bindings/src/console.rs:26:16
   |
26 |     pub struct console<M>(ethers::contract::Contract<M>);
   |                ^^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Console`
   |
   = note: `#[warn(non_camel_case_types)]` on by default

Solution

add allow(non_camel_case_types) to binding namespace

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

eg the `console` contract throws a clippy warning
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - seems fine to me

@gakonst gakonst marked this pull request as ready for review May 27, 2022 20:32
@gakonst gakonst merged commit 7b9503c into gakonst:master May 27, 2022
mattsse pushed a commit to mattsse/ethers-rs that referenced this pull request May 28, 2022
eg the `console` contract throws a clippy warning
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants