Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making ethers-solc optional #1457

Closed
mattsse opened this issue Jul 5, 2022 · 1 comment · Fixed by #1463
Closed

Consider making ethers-solc optional #1457

mattsse opened this issue Jul 5, 2022 · 1 comment · Fixed by #1463
Labels
good first issue Good for newcomers

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 5, 2022

ethers-solc has grown quite large and is probably not useful for most ethers users

making it optional, and therefore opt-in will significantly decrease compile time and get rid of deps
@gakonst
Copy link
Owner

gakonst commented Jul 6, 2022

just a matter of optional = true here https://github.com/gakonst/ethers-rs/blob/master/Cargo.toml#L91, good first issue

@gakonst gakonst added the good first issue Good for newcomers label Jul 6, 2022
@mattsse mattsse mentioned this issue Jul 6, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: make ethers-solc optional mattsse/ethers-rs
2 participants
@gakonst @mattsse