Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

ethers-signers/aws: sighash on the inner/updated tx object #1977

Merged
merged 1 commit into from
Jan 3, 2023
Merged

ethers-signers/aws: sighash on the inner/updated tx object #1977

merged 1 commit into from
Jan 3, 2023

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Dec 27, 2022

Signed-off-by: Gyuho Lee [email protected]

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Hard to test these -_-

@gakonst gakonst merged commit 04e3021 into gakonst:master Jan 3, 2023
@gyuho gyuho deleted the kms branch January 3, 2023 14:23
Rjected pushed a commit to Rjected/ethers-rs that referenced this pull request Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants