This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
per request error shouldn't be eargerly evaulated as a global websocket error #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanqun
force-pushed
the
per-request-error
branch
from
54dcdf2
to
da306fd
Compare
guanqun
force-pushed
the
per-request-error
branch
from
da306fd
to
6ebc21a
Compare
hanyunx
pushed a commit
to hanyunx/ethers-rs
that referenced
this pull request
Jun 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here is that once a request has error, the transport layer evaulates it eagerly and thinks it's a websocket error.