This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix: preserve from field in SignerMiddleware #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Jul 27, 2021
|
Looks good! Thank you! |
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
gakonst#350) Otherwise we may start over from dirty state from a previous unit or fuzz test and that can break test isolation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #349
Solution
send_transaction()attempts to preserve the from field of a TransactionRequest by forwarding toinner.send_transaction()in the case when a from address other than the signer address is specifiedsign_transaction()returns aWrongSignererror if asked to sign a TransactionRequest with a from address other than the signer specified.It might make sense for
sign_transaction()to sign and replace the from field anyway, since it is explicitly being asked to sign from that address.