This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix: drop WS server if work complete #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updateadded an |
mattsse
force-pushed
the
fix-leaky-ws-server
branch
from
ef8660e
to
052efa5
Compare
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* Pull latest ethers * Do not suppress warnings on build * Add `--ignored-error-codes` option * chore: remove double success with warnings log * chore: fix dai resolve addr test https://github.com/gakonst/ethers-rs/pull/771/files * fix: do not log output warnings if ignored using gakonst#775, warnings for test contracts are not going to be logged. Co-authored-by: Georgios Konstantopoulos <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This fixes another edge case that leads to active WS servers with not possibility of future work.
If all instruction senders are dropped there are no more subscriptions or pending requests, then this leaves the Ws server with nothing todo and since the receiver can't receive any more instructions it's effectively useless, running in the background with, still connected to the ws server and occasionally receiving/sending pings/pongs.
Also Subscriptions with a closed channel also remained active.
Solution
subscriptionsif its channel was closed