This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(solc): exclude sha2 asm feature for msvc #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Dec 12, 2021
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Dec 13, 2021
|
I have solved this by change to gnu-windows just in case anyone is looking for a quickfix. |
charisma98
added a commit
to charisma98/foundry
that referenced
this pull request
Mar 4, 2023
0129general
added a commit
to 0129general/FoundryProject
that referenced
this pull request
May 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
MSVC is not supported for sha2 asm RustCrypto/asm-hashes#17
Solution
We disable asm if the target is msvc
PR Checklist