This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(chain): enum values + TryFrom<u64> #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
suggested changes
Jan 10, 2022
tarrencev
commented
Jan 10, 2022
ethers-core/src/types/chain.rs
Outdated
| impl TryFrom<u64> for Chain { | ||
| type Error = (); | ||
|
|
||
| fn try_from(chainid: u64) -> Result<Chain, Self::Error> { |
There was a problem hiding this comment.
we could use a crate like https://crates.io/crates/num_enum to avoid duplicating the mapping here
There was a problem hiding this comment.
i think it's fine as-is, if we see the maintenance of this becoming a problem we can consider
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream changes to support feedback at foundry-rs/foundry#412
cc @mattsse