Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support I256 in format_units and parse_units #842

Closed
mds1 opened this issue Jan 29, 2022 · 0 comments · Fixed by #1863
Closed

Support I256 in format_units and parse_units #842

mds1 opened this issue Jan 29, 2022 · 0 comments · Fixed by #1863
Labels
enhancement New feature or request

Comments

@mds1
Copy link

mds1 commented Jan 29, 2022

format_units and parse_units only support U256 and are do not let you use I256 as the input or output type

I think these methods should probably take/return something similar to enum BigInt { Int(I256), Uint(U256) } and match on that. I'm not sure if additional enum types are required to support smaller input types like u128, i128, etc.

Support for this would make full signed integer support in cast much simpler. This is also required to fix the LogNamedDecimalIntFilter method in forge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants