This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(ethers-contract): add send_with_receipt to Deployer
#865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Deployer` is used to deploy contracts and its `send` function returns an attached instance of a `Contract`. There is no way to know the transaction hash of the deployment transaction, so this commit adds another method `send_with_receipt` that returns an attached `Contract` as well as a `TransactionReceipt`.
gakonst
approved these changes
Feb 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'd like to print the transaction hash when using
forge createand its just generallyuseful to have a reference to the receipt when deploying a contract. Currently
this is not possible due to the interface on the
DeployerSolution
The
Deployeris used to deploy contracts and itssendfunction returns an attached instance of a
Contract.There is no way to know the transaction hash of the
deployment transaction, so this commit adds another
method
send_with_receiptthat returns an attachedContractas well as aTransactionReceipt.PR Checklist