Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix(solc): fix cache and allowed paths bug #998

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 9, 2022

Motivation

This fixes several issues that were discovered on https://github.com/maple-labs/loan/releases/tag/v3.0.0-beta.0

  • don't emit anything (cache/artifacts) if there are errors in the project output
  • an erroneous condition when checking allowed-paths
  • when filtering dirty files, also include their imports in the CompilerInput so that solc doesn't need to look them up

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@gakonst gakonst merged commit 0c42c23 into gakonst:master Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants