Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: substrate 3 upgrade #141

Merged
merged 42 commits into from
Mar 16, 2021
Merged

refactor!: substrate 3 upgrade #141

merged 42 commits into from
Mar 16, 2021

Conversation

enthusiastmartin
Copy link
Contributor

No description provided.

enthusiastmartin and others added 16 commits March 10, 2021 11:32
@enthusiastmartin
refactor: substrate 3 upgrade
f559a1e
@enthusiastmartin
fix: clippy
5df54a6
@enthusiastmartin
test(amm): tests adjusted for substrate3
53e035b
@enthusiastmartin
test(asset registry): tests adjusted for substrate3
3cb0119
@enthusiastmartin
test(exchange): tests adjusted for substrate3
666258c
@enthusiastmartin
test(faucet): tests adjusted for substrate3
39df661
@enthusiastmartin
test(multipayment): tests adjusted for substrate3
a48e110
@enthusiastmartin
test(claims): tests adjusted for substrate3
693e78c
@martinfridrich
fix: block finalization
85a8942
@martinfridrich
refactor: telemetry_on_connect
ccf4509
@enthusiastmartin
test(amm): benchmarking tests fixed for substrate3
31ab6a0
@enthusiastmartin
test(exchange): benchmarking tests fixed for substrate3
d5e826f
@enthusiastmartin
test(multipayment): benchmarking tests fixed for substrate3
32a2524
@enthusiastmartin
Merge branch 'refactor/substrate_3' of github.com:galacticcouncil/Hyd…
ed37011 
…raDX-node into refactor/substrate_3
@enthusiastmartin
refactor(assetregistry): migrate to new pallet macro
080ab4e
@enthusiastmartin
refactor(amm): migrate to new pallet macro
5a6af53
mrq1911
mrq1911 reviewed Mar 12, 2021
View reviewed changes
pallets/amm/src/tests.rs Outdated Show resolved Hide resolved
@enthusiastmartin enthusiastmartin marked this pull request as ready for review March 15, 2021 21:46
@enthusiastmartin
Copy link
Contributor Author

Probably needs spec_version bump ?

@jak-pan
Copy link
Contributor

jak-pan commented Mar 15, 2021

yes

jak-pan
jak-pan reviewed Mar 15, 2021
View reviewed changes
node/Cargo.toml Outdated Show resolved Hide resolved
@mrq1911
Copy link
Member

mrq1911 commented Mar 15, 2021

now i remember why i disabled clippy in cumulus branch :)

@enthusiastmartin
Copy link
Contributor Author

now i remember why i disabled clippy in cumulus branch :)

yes, lot of it is actually in the new substrate's macros. Also new toolchain has new rules too.

I put a todo task on my list to follow it up later on.

jak-pan
jak-pan reviewed Mar 15, 2021
View reviewed changes
Copy link
Contributor

@jak-pan jak-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions. Looks huge btw.

runtime/src/lib.rs Outdated Show resolved Hide resolved
node/src/service.rs Outdated Show resolved Hide resolved
pallets/amm/src/mock.rs Outdated Show resolved Hide resolved
pallets/asset-registry/src/mock.rs Outdated Show resolved Hide resolved
pallets/amm/src/mock.rs Outdated Show resolved Hide resolved
pallets/faucet/src/mock.rs Outdated Show resolved Hide resolved
pallets/transaction-multi-payment/src/lib.rs Outdated Show resolved Hide resolved
pallets/transaction-multi-payment/src/lib.rs Show resolved Hide resolved
pallets/transaction-multi-payment/src/lib.rs Show resolved Hide resolved
pallets/transaction-multi-payment/src/mock.rs Outdated Show resolved Hide resolved
@jak-pan
Copy link
Contributor

jak-pan commented Mar 15, 2021

Got a slight problem over here related to M1 now.
Screenshot 2021-03-16 at 00 18 59

@jak-pan
Copy link
Contributor

jak-pan commented Mar 15, 2021

Looks like the UI now works.

@enthusiastmartin enthusiastmartin merged commit 3fb705c into master Mar 16, 2021
@jak-pan jak-pan changed the title refactor: substrate 3 upgrade refactor!: substrate 3 upgrade Mar 21, 2021
@jak-pan jak-pan mentioned this pull request Mar 22, 2021
Closed
@mrq1911 mrq1911 deleted the refactor/substrate_3 branch April 6, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jak-pan jak-pan jak-pan approved these changes

@mrq1911 mrq1911 Awaiting requested review from mrq1911

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enthusiastmartin @jak-pan @mrq1911 @martinfridrich