fix(claims): update Alice's signature in claims bench test

[green-jay]

No description provided.

[enthusiastmartin]

Still getting the same error unfortunately.

---- benchmarking::tests::test_benchmarks stdout ----
thread 'benchmarking::tests::test_benchmarks' panicked at 'Expected Ok(_). Got Err(
    "NoClaimOrAlreadyClaimed",
)', pallets/claims/src/benchmarking.rs:35:13

[green-jay]

@jak-pan why the commit message rename? AFAIK conventional commits should be in imperative form... although thinking about it, it is indeed more natural like "fix: noun". Btw. where can I find the guidelines?

[green-jay]

@enthusiastmartin this is strange, I get test result OK. What command do you use?

[enthusiastmartin]

@enthusiastmartin this is strange, I get test result OK. What command do you use?

to run benchmark tests - you have to buld with runtime-benchmarks features.

cargo test --features runtime-benchmarks -p pallet-claims

[green-jay]

@enthusiastmartin hmm, that way I get

error: --features is not allowed in the root of a virtual workspace
note: while this was previously accepted, it didn't actually do anything

[jak-pan]

@jak-pan why the commit message rename? AFAIK conventional commits should be in imperative form... although thinking about it, it is indeed more natural like "fix: noun". Btw. where can I find the guidelines?

Imperative is just a good practice but you are right we should use it if possible, guidelines are being worked on. The update was more of a 🐛 removal than about update word so we can readd that.

[enthusiastmartin]

@enthusiastmartin hmm, that way I get

error: --features is not allowed in the root of a virtual workspace
note: while this was previously accepted, it didn't actually do anything

run it inside node directory.

[green-jay]

thanks, now I get the error too, will check it

[enthusiastmartin]

One last minor issue. but then lgtm.

[jak-pan]

bump cargo.toml and implementation version pls :)