Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add contributing guidelines #144

Merged
merged 22 commits into from
Mar 16, 2021
Merged

docs: add contributing guidelines #144

merged 22 commits into from
Mar 16, 2021

Conversation

RoboRambo
Copy link
Contributor

Partially resolves #121

@RoboRambo
Copy link
Contributor Author

Tried to keep it simple, suggestions welcome :)

@RoboRambo RoboRambo marked this pull request as ready for review March 11, 2021 23:20
@RoboRambo RoboRambo marked this pull request as draft March 11, 2021 23:22
@RoboRambo RoboRambo marked this pull request as ready for review March 11, 2021 23:35
jak-pan
jak-pan reviewed Mar 11, 2021
View reviewed changes
docs/CONTRIBUTING.adoc Outdated Show resolved Hide resolved
@RoboRambo RoboRambo marked this pull request as draft March 11, 2021 23:46
@RoboRambo
docs: added STYLE_GUIDE
a91df31 
adjusted README & CONTRIBUTING
@jak-pan jak-pan marked this pull request as ready for review March 14, 2021 23:00
@jak-pan
Copy link
Contributor

jak-pan commented Mar 14, 2021 •
edited
Loading

I've updated the contributing guide to be more precise and did some other small changes. If we're OK with this please merge the new stuff here also: https://github.com/galacticcouncil/guidelines-example

@RoboRambo
Copy link
Contributor Author

i was wondering the same thing, thanks for the feedback.
ill try to shorten things up

@jak-pan
Copy link
Contributor

jak-pan commented Mar 15, 2021

We need to change the conventional commit messages enforcement from any commit to just PR names. https://github.com/zeke/semantic-pull-requests#configuration

enthusiastmartin
enthusiastmartin reviewed Mar 16, 2021
View reviewed changes
Copy link
Contributor

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor two comments. otherwise looks goo.d

.github/ISSUE_TEMPLATE/bug-report.md

### Your Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
* Version used:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Info about how to get the actual version might be useful too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to keep this generic and push to every project so that we can sync this.

.github/ISSUE_TEMPLATE/bug-report.md Show resolved Hide resolved
@jak-pan jak-pan changed the title Add contributing guidelines docs: add contributing guidelines Mar 16, 2021
@jak-pan
Copy link
Contributor

jak-pan commented Mar 16, 2021

I'm happy with this right now. Will merge this. We can open new PRs for additions/updates. Thank you guys, especially @RoboRambo !

@jak-pan jak-pan merged commit 1f2ef59 into galacticcouncil:master Mar 16, 2021
@jak-pan jak-pan changed the title docs: add contributing guidelines docs: add contributing guidelines Mar 21, 2021
@auto-add-label auto-add-label bot added the documentation Improvements or additions to documentation label Mar 21, 2021
@jak-pan jak-pan changed the title docs: add contributing guidelines docs: add contributing guidelines Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jak-pan jak-pan jak-pan approved these changes

@enthusiastmartin enthusiastmartin enthusiastmartin left review comments

@mrq1911 mrq1911 Awaiting requested review from mrq1911

@martinfridrich martinfridrich Awaiting requested review from martinfridrich

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve contributing guidelines
3 participants
@RoboRambo @jak-pan @enthusiastmartin