feat!: disable slashing #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
green-jay
reviewed
Mar 26, 2021
runtime/src/lib.rs
Outdated
| type SlashCancelOrigin = EnsureOneOf< | ||
| AccountId, | ||
| EnsureRoot<AccountId>, | ||
| pallet_collective::EnsureProportionAtLeast<_3, _4, AccountId, CouncilCollective>, |
There was a problem hiding this comment.
as there will be only once council member, EnsureMember makes a bit more sense
There was a problem hiding this comment.
I have to fix babe/grandpa equivocations at first for slashing to start to work. I can make it in 2 issues/PRs if we want
There was a problem hiding this comment.
Ok so the slashing wasn't working in the first place, got it. Probably no need to split it at this point.
auto-add-label
bot
added
breaking-change
and removed
enhancement
|
Bump runtime and spec_version pls |
|
Oops. I'll fix this. |
jak-pan
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Delay slashing to infinity so slashes can be canceled with sudo
Related Issue
#145