fix!: set DOLLARS constant to correct number #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please try to re-test this. What happens with already set identities? |
jak-pan
changed the title
|
It's safe to update the DOLLARS constant. Identity pallet stores a deposit value for each account and this value is returned when you are no longer interested in using this feature. When you decide to update your data, the difference is reserved( newly calculated deposit - what is already deposited). The previous 'pattern" is also used in the Treasury pallet and the Elections phragmen pallet (where is the DOLLARS constant variable also used). It has been tested for the identity pallet, the updated storage price for identities is 50 HDX = 5$ ( as expected ). |
Roznovjak
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've set wrong DOLLARS constant the transactions are too cheap and the storage for identities is 0.05$ instead of 5$