feat: create testing runtime #226
Conversation
|
The following params have been modified: Calls are not filtered ReportLongevity = BondingDuration * SessionsPerEra * EpochDuration |
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
=======================================
Coverage 15.27% 15.27%
=======================================
Files 20 20
Lines 6776 6776
=======================================
Hits 1035 1035
Misses 5741 5741
Continue to review full report at Codecov.
|
| @@ -0,0 +1,352 @@ | |||
| //! HydraDX Client abstractions | |||
There was a problem hiding this comment.
I believe it is needed because of the abstraction and generics used in service.rs file.
| @@ -34,7 +34,8 @@ use frame_support::sp_runtime::{ | |||
| }; | |||
| use frame_support::{dispatch::DispatchResult, ensure, traits::Get, transactional}; | |||
| use frame_system::ensure_signed; | |||
| use primitives::{asset::AssetPair, fee, traits::AMM, AssetId, Balance, Price, MAX_IN_RATIO, MAX_OUT_RATIO}; | |||
| use primitives::{asset::AssetPair, fee, traits::AMM, AssetId, Balance, Price}; | |||
| use common_runtime::constants::chain::{MAX_IN_RATIO, MAX_OUT_RATIO}; | |||
There was a problem hiding this comment.
I think it makes sense to store common constants in common_runtime. There is also an option to create a new submodule for constants in primitives module.
|
Just some general questions about possible improvements but other than that LGTM. |
|
Update docs pls and we can merge |
Description
Create new testing node and runtime
Related Issue
Fixes: #150
Local copy of #197
Motivation and Context
Current implementation filters certain extrinsic calls. Testing runtime does not block any calls and makes testing easier.