refactor(build-script): allow to specify runtime #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In build-script-utils , there is runtime name hardcoded to "hydra-dx-runtime". That means, it is only possible to use it with that given runtime.
This PR is making this value configurable so it is possible to use with different runtimes.
In Basilisk, for example - we don't need to have the same utils but could use the crate from hydradx-node repo.
Related Issue
Nope.
Motivation and Context
To be able to use it in Basilisk or even with testing runtime ( when support for this is merged ) - it would be great to have a possibility to specify runtime name for which cargo keys should be generated.
How Has This Been Tested?
Locally.