-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: WithFee::with_fee method #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok to me. but i am not very convinced that we need to update all versions of all pallets and runtime too.
I would just update the primitives crate version.
What do you think @jak-pan ? It is a breaking change, but the affected method was never used before in the code( at least not in this repository). |
Just runtime and impl_version in runtime. Where else is this used? |
We don't use |
Only runtime then. |
I have reverted impl_runtime version to the previous one. The only version changes are now in |
Description
fix WithFee::with_fee() method and also add without_fee() method.
https://github.com/galacticcouncil/HydraDX-node/blob/694cce69ee44890dcbd05c9ef1cd83079e3ce1ac/primitives/src/lib.rs#L121-L124
The current implementation computes
value * (100% - fee_percentage)
instead ofvalue + fee