fix(amm): buy_price calculation #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roznovjak
requested review from
enthusiastmartin,
jak-pan,
green-jay,
mrq1911 and
martinfridrich
|
Btw i dont think this is a breaking change. IT is just implementation change but it does not break anything. |
|
You are right. A change in behavior to fix a bug is not considered as a breaking change. |
Roznovjak
changed the title
enthusiastmartin
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fee in buy_price calculation is wrongly assigned to the
amount_out. The correct operation order is to computeamount_infirst, and then apply fee to this value in the next step.