feat: add fee to AMMTransfer #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roznovjak
requested review from
martinfridrich,
mrq1911,
jak-pan and
enthusiastmartin
enthusiastmartin
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AMMTransfer struct is extended to contain two new fields: fee_assetID and fee_amount.
Description
The fee amount is subtracted from the amount_in variable in the AMMTransfer struct.
Motivation and Context
This change is required in LBP pallet because we need a way to access the fee in
execute_buy/sell(transfer: AMMTransfer)functions and send it to corresponding fee_receiver account.