chore!: v0.9.5 #283
Merged
chore!: v0.9.5 #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roznovjak
reviewed
Jun 24, 2021
green-jay
reviewed
Jun 25, 2021
| orml_tokens::Event::Reserved(asset_a, 2, 1000000000000).into(), | ||
| orml_tokens::Event::Reserved(asset_b, 3, 2000000000000).into(), | ||
| orml_tokens::Event::Reserved(asset_b, 2, 2000000000).into(), | ||
| orml_tokens::Event::Reserved(asset_b, 3, 4000000000).into(), |
There was a problem hiding this comment.
was wondering if this repetitive part could be setup and reused as a function?
There was a problem hiding this comment.
yes.possibly. but i have noticed little discrepancy in this, so i investigate that first. And when all good, we can handle this kind of improvement.
green-jay
reviewed
Jun 25, 2021
| @@ -210,6 +210,7 @@ impl Filter<Call> for BaseFilter { | |||
|
|
|||
| Call::XYK(_) | |||
| | Call::AssetRegistry(_) | |||
| | Call::Balances(_) | |||
There was a problem hiding this comment.
will staking, governance etc. work?
There was a problem hiding this comment.
Yes, it should. It was tested previously with treasury tip.
mrq1911
requested changes
Jun 27, 2021
mrq1911
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v0.9.5