Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pool id to xyk pool created/destroyed events #300

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

enthusiastmartin
Copy link
Contributor

No description provided.

@auto-add-label auto-add-label bot added the bug Something isn't working label Aug 20, 2021
@jak-pan
Copy link
Contributor

jak-pan commented Aug 20, 2021

@enthusiastmartin can we also add pair_account to the events?

@mckrava
Copy link
Contributor

mckrava commented Aug 20, 2021

But this commit fix: add pool id to xyk pool created/destroyed events adds shared_token_id but not pool id :)

pallets/xyk/src/lib.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #300 (dba22ee) into master (394b20e) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   15.27%   15.37%   +0.09%     
==========================================
  Files          20       20              
  Lines        6776     6784       +8     
==========================================
+ Hits         1035     1043       +8     
  Misses       5741     5741              
Impacted Files Coverage Δ
pallets/xyk/src/lib.rs 84.43% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03391a6...dba22ee. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants