Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amm): calculation fixes + price type change #7

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Conversation

enthusiastmartin
Copy link
Contributor

No description provided.

@jak-pan
Copy link
Contributor

jak-pan commented Aug 21, 2020

We should also update type definitions for polkadot-js.
I'd use Balance or U128 for price right now as there is no dedicated input in polkadot apps for that yet.

@jak-pan jak-pan merged commit f2397ea into master Aug 24, 2020
@jak-pan jak-pan deleted the fix/maths branch October 20, 2020 08:04
jak-pan pushed a commit that referenced this pull request Mar 16, 2021
@jak-pan jak-pan changed the title Amm calculation fixes/price type change fix(amm): calculation fixes + price type change Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants