Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup scopes that can be used in conventional commits #143

Closed
jak-pan opened this issue Mar 11, 2021 · 1 comment
Closed

Setup scopes that can be used in conventional commits #143

jak-pan opened this issue Mar 11, 2021 · 1 comment
Labels

Comments

@jak-pan
Copy link
Contributor

jak-pan commented Mar 11, 2021

As some of you guys started to use this, I feel like we really need to only enforce only the merge commit names. #139

If you feel like there is something important in a commit, you can also use this. Do this only when necessary as right now we haven't setup scopes like fix(amm): fixed naming of methods because if you do it for every single commit - like fix: clippy, this doesn't add any valuable information to the change log and the PR will now pass the check. I suggest using scopes to properly construc changelogs.

@jak-pan jak-pan added the ci label Mar 29, 2021
@jak-pan
Copy link
Contributor Author

jak-pan commented Jul 12, 2021

done

@jak-pan jak-pan closed this as completed Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant