Semantic DOM Feedback!

[rijkvanzanten]

• Do we really need to add in explicit support for Internet Explorer? It has been end of life for over two years now 🙂
• I'd bet money on this being an HTML5 boilerplate and not something you came up with yourself. No attribution either, which would make it plagiarism. Not good!
• I'd just drop the meta description if you're not using it
• Keep spacing consistent. Sometimes you're using id ="author", sometimes id = "intro" sometimes id="modern9". Keep it consistent; I'd recommend always using attribute="value" without spaces.
• Is a table the right format for this content? It's a list of 10 ordered things, I'd argue an ordered list <ol> is the better tool for the job
• When you find yourself adding incremental IDs, eg modern1, modern2, modern3, you're probably looking to use a class of modern instead. If you need to target them by index in CSS, you can use the nth-child or nth-of-type selectors
• Feels like you're abusing <br> tags to achieve some spacing. See MDN on what a break tag is for
• Once we get further down your page, the spacing gets increasingly inconsistent. Sometimes tabs, sometimes spaces, sometimes one more, one too many etc
• Are headings the right tool for an author or article date?
• We're not doing anything with JavaScript yet, and this is an empty reference which won't do anything. Again fairly sure this is just copy pasted from some boilerplate example somewhere.

Ah yes, it's just html5-boilerplate. Big bummer.

[gallr091]

Hi Rijk, thanks for this feedback!

I am so sorry about the boilerplate. I didn't know it would be considered plagiarism to use it. When I first learned HTML (also at Parsons) this is what we were taught and we were not told to credit it in the code so I wasn't aware... will I get in trouble for this? :(

[rijkvanzanten]

All good! As we discussed on Slack, it's fine for now. There's a great question in there somewhere about good defaults, attributes, and derivative work. In this case, I couldn't help but notice bits of code in there that are objectively pointless in the context of this project and class. When using boilerplates it's very important to make sure the stuff in there is actually stuff you want to have 🙂