Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject filenames that would be invalid on Windows #96

Open
fingolfin opened this issue Jan 18, 2023 · 0 comments
Open

Reject filenames that would be invalid on Windows #96

fingolfin opened this issue Jan 18, 2023 · 0 comments

Comments

@fingolfin
Copy link
Member

For a time, hap was shipping with a file named :q, specifically lib/Functors/:q, which apparently causes trouble on Windows (CC @ChrisJefferson). Clearly that file was created by accident while using vim or a similar editor.

Ideally ReleaseTools (and the PackageDistro tools) would reject problematic filenames like these. I guess at the very lest : and \ should be prevented. Maybe more. Perhaps also special filenames like CON / AUX / ... (also in different case variants; see https://learn.microsoft.com/en-gb/windows/win32/fileio/naming-a-file?redirectedfrom=MSDN) should be rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant