Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update etcd imports and vendor to github.com/etcd-io/etcd #49

Closed
swapnilgm opened this issue Aug 8, 2018 · 4 comments · Fixed by #269
Closed

Update etcd imports and vendor to github.com/etcd-io/etcd #49

swapnilgm opened this issue Aug 8, 2018 · 4 comments · Fixed by #269
Assignees
@shreyas-s-rao
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related effort/2m Effort for issue is around 2 months exp/beginner Issue that requires only basic skills kind/api-change API change with impact on API users lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/all status/external-action Issue has external dependency

Comments

@swapnilgm
Copy link
Contributor

As per announcment soon coreos community is moving etcd and other sub-projects to its own GitHub organization.
Reference: etcd-io/etcd#9965.
Probably old path will continue to work with github redirection. Still since its recommended lets re-vendor it.
@swapnilgm swapnilgm added exp/beginner Issue that requires only basic skills area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related platform/all kind/api-change API change with impact on API users priority/normal size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/new Issue is new and unprocessed labels Aug 8, 2018
@swapnilgm swapnilgm added status/external-action Issue has external dependency and removed status/new Issue is new and unprocessed labels Sep 18, 2018
@shreyas-s-rao
Copy link
Collaborator

The latest tagged version of etcd is 3.3.9 (July 24th), which was released before the migration announcement was made (issue #9965 raised on July 28th). Hence, it does not incorporate the new repo imports yet and trying to vendor this version leads to vendoring of the old repo as well, resulting in object mismatch errors within the code.

It is advisable to wait for version 3.3.10 of etcd for the revendoring to work.

@msohn
Copy link
Member

msohn commented Sep 18, 2018

when you do the update please also update the link in
https://github.com/gardener/etcd-backup-restore/blob/master/LICENSE.md
to the new repository location

@shreyas-s-rao
Copy link
Collaborator

Definitely @msohn

@swapnilgm swapnilgm added this to the 0.5.0 milestone Oct 24, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 24, 2018
@swapnilgm swapnilgm modified the milestones: 0.5.0, 0.6.0 Feb 19, 2019
@swapnilgm swapnilgm removed this from the 0.6.0 milestone Mar 25, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels May 24, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 23, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Sep 22, 2019
@shreyas-s-rao
Copy link
Collaborator

This issue shall be addressed when updating to etcd version to 3.4.

@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 23, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Feb 22, 2020
@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Apr 23, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 23, 2020
@shreyas-s-rao shreyas-s-rao mentioned this issue Oct 6, 2020
Merged
@gardener-robot gardener-robot added effort/2m Effort for issue is around 2 months and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shreyas-s-rao shreyas-s-rao

Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related effort/2m Effort for issue is around 2 months exp/beginner Issue that requires only basic skills kind/api-change API change with impact on API users lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/all status/external-action Issue has external dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revendor etcd library to v3.4.13 shreyas-s-rao/etcd-backup-restore
5 participants
@msohn @swapnilgm @gardener-robot-ci-1 @shreyas-s-rao @gardener-robot