Support for service accounts managed by Gardener operators #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/security
gardener-robot-ci-2
added
reviewed/ok-to-test
dkistner
force-pushed
the
feature/managed-service-account
branch
from
15694e6
to
0c6d4a3
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
dkistner
force-pushed
the
feature/managed-service-account
branch
from
0c6d4a3
to
e7a812f
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
dkistner
force-pushed
the
feature/managed-service-account
branch
from
e7a812f
to
54b0743
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
dkistner
force-pushed
the
feature/managed-service-account
branch
from
54b0743
to
4f64496
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
/ready-for-review |
kon-angelo
reviewed
Jan 17, 2022
| @@ -0,0 +1,130 @@ | |||
| // Copyright (c) 2021 SAP SE or an SAP affiliate company. All rights reserved. This file is licensed under the Apache Software License, v. 2 except as noted otherwise in the LICENSE file | |||
There was a problem hiding this comment.
Small nit but I think copyrights should be 2022
|
@dkistner You need rebase this pull request with latest master branch. Please check. |
gardener-robot
added
the
lifecycle/stale
|
/close currently there is no work on this topic. Reopen a new pr when it become relevant again. |
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area security
/kind enhancement
/platform gcp
What this PR does / why we need it:
Add support to use a service account managed by Gardener operators for a GCP Shoot.
This eliminates the need for users to bring their own service account.
The service account can be managed by the Gardener operator in a different project in the same GCP organisation.
Users just need to assign the managed service account to their own project with proper permissions.
This gives the operator also the ability to rotate credentials in centralised way.
Which issue(s) this PR fixes:
Fixes #362
Special notes for your reviewer:
Release note:
Draft until a few pending tests are completed.
/squash
/cc @donistz