Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extracted contents of release tarball as artifacts #3

Closed
mxmxchere opened this issue Sep 3, 2024 · 1 comment · Fixed by #2
Closed

Use extracted contents of release tarball as artifacts #3

mxmxchere opened this issue Sep 3, 2024 · 1 comment · Fixed by #2
Assignees
Milestone

Comments

@mxmxchere
Copy link
Contributor

mxmxchere commented Sep 3, 2024

An important step for the (initial) publishing of a new target-asset-set (maybe I will find a etter name for it soon) is to detect the artifacts that have been created by the builder. The current approach traverses the feature-tree and includes all artifacts that are created by convert.* scripts. This approach does not detect all relevant artifacts (logs for example are missing). According to @5kt the contents of the tarballs in the end of the build process should be a pretty good fit (except for the nested artifacts for PXE for example, but this is going to be addressed in another issue).

I will try not to duplicate any code, unless possible. So the challenge is to find an elegant drop-in point to reuse as much code as possible.

To detect and push release assets of a build the current command line call is as follows

glcli oci push --container localhost:5000/test1 --architecture amd64 --cname kvm_dev --version 1443.9 --gardenlinux_root /home/muench/vcs/git/gardenlinux

My idea is to have a new command push-tarball which is intended to be called by the CI the command above can then still be used when running locally on a dev-station.

glcli oci push-tarball --container localhost:5000/test1 --tarball  ali-gardener_prod-amd64-1592.1-ec945aa9.tar.xz 

This approach will rely on the filename to read arch, cname and version and will detect the artifacts by unpacking the tarball and push each extracted file as its own layer.

@mxmxchere
Copy link
Contributor Author

I think valuable steps to test next are

  • push all release tarballs of a release (to detect if all file-types are known yet)
  • push some release tarballs in parallel to see if we have a race condition when signing the index

@pnpavlov pnpavlov transferred this issue from gardenlinux/gl-oci Sep 10, 2024
@pnpavlov pnpavlov linked a pull request Sep 10, 2024 that will close this issue
@mxmxchere mxmxchere changed the title Detect artifacts (needs to be figured out), probably extracted contents of the tarball is the best Use extracted contents of release tarball as artifacts Sep 10, 2024
@pnpavlov pnpavlov added this to the 2024-09 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants