feat: automatically remove Apples quarantine flag #155
Conversation
Apple usually puts a quarantine flag on downloaded binaries, that are not signed. This prevents execution of the file. This PR adds a command to the `install.sh` file, to automatically remove the quarantine flag of the installed binary. *tested on macOS 14.x*
| @@ -74,6 +74,7 @@ if [ "$OS" = "Darwin" ]; then | |||
| install_unix | |||
| create_launchd_plist | |||
| enable_launchd_plist | |||
| sudo xattr -r -d com.apple.quarantine /usr/local/bin/backrest # remove quarantine flag | |||
There was a problem hiding this comment.
nit: let's pull off -r since it's operating directly on the binary! Shouldn't be needed.
There was a problem hiding this comment.
True, I'll fix it when I am back home :)
There was a problem hiding this comment.
Thanks! As a side note I see you maintain https://github.com/installer/instl, how maintained is it / would it be a good candidate for download metrics for backrest? Getting some usage data to display on the repo is in my backlog and I like the idea of using an OSS platform for transparency.
There was a problem hiding this comment.
Instl is usable, but I don't actively work on it at the moment. I want to revive it tho, as I still love the idea.
However, GitHub features a download count API, which can be utilized via shields.io do make a badge:
https://img.shields.io/github/downloads/garethgeorge/backrest/total
You can configure the badge with additional settings here:
https://shields.io/badges/git-hub-downloads-all-assets-all-releases
|
This looks great, thanks for the PR! |
|
Hi, I'm evaluating relicensing Backrest as AGPL-3.0 . Thanks for contributing this improvement, I suspect it has very much streamlined MacOS installs for a lot of users in the last 4 or so months. I'm wondering if you'd be willing to retroactively sign a CLA? Or grant more specific permission to retain the copyright for your PRs but relicense your changes in the codebase under AGPL-3.0 . I've become aware of a few SAAS looking at selling Backrest which goes philosophically against what I created it for (well they're welcome to -- but their platforms should be OSS and self-hostable re: the same freedoms Backrest provides!). |
|
Signed the CLA, feel free to do anything you want with my one line contribution 😆 |
|
Haha, much appreciated :) |
Apple usually puts a quarantine flag on downloaded binaries, that are not signed. This prevents execution of the file. This PR adds a command to the
install.shfile, to automatically remove the quarantine flag of the installed binary.tested on macOS 14.x