fix: Linux ./install.sh script fails when used for updating backrest #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the systemd service is already running, and stop it before installing. Do not overwrite the existing backrest service file.
|
Nice! Changes look great and the explicit checks are definitely an improvement. Thanks for the PR. |
|
Hi, I'm evaluating relicensing Backrest as AGPL-3.0 . Thanks for contributing this fix! I'm wondering if you'd be willing to retroactively sign a CLA? Or grant more specific permission to retain the copyright for your PRs but relicense your changes in the codebase under AGPL-3.0 . I've become aware of a few SAAS looking at selling Backrest which goes philosophically against what I created it for (well they're welcome to -- but their platforms should be OSS and self-hostable re: the same freedoms Backrest provides!). |
|
Sure, I just signed the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When backrest is already installed, and the script is used for updating (as with #187), the install might fail:
If backrest is already running, the cp in the install script fails with "Text file is busy". If the service is already existing, maybe containing customized configuration, it is overwritten. This PR fixes both.
Check if the systemd service is already running, and stop it before installing. Do not overwrite the existing backrest service file.