Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overhaul task interface and introduce 'flow ID' for simpler grouping of operations #253

Merged
merged 18 commits into from
Apr 29, 2024

Conversation

garethgeorge
Copy link
Owner

@garethgeorge garethgeorge commented Apr 29, 2024

Significant refactoring of the task interface to decouple it from the orchestrator.

Simultaneously introduces a new concept of a flow ID which is used to group operations in the UI rather than relying on the snapshot ID (which has made for complex handling in the past). Now all operations have a known and immutable flow ID from creation. Any operations belonging to the same flow are explicitly placed in the correct flow as determined either by

  • the task that scheduled the operation may ask it's child tasks to inherit the flow ID
  • or if a snapshot ID is known the oplog may be queried to find the flow ID for the backup operation that created the snapshot (e.g. to place an indexed snapshot in the same flow as the backup that created it).

This PR also bundles some fixes and reliability improvements that weren't worth forking out into their own commits.

@garethgeorge garethgeorge changed the title feat: refactor task interface to decouple tasks from orchestrator and simplify operation management feat: general refactoring and reliability improvements Apr 29, 2024
@garethgeorge garethgeorge changed the title feat: general refactoring and reliability improvements feat: overhaul task interface and introduce 'flow ID' for simpler grouping of operations Apr 29, 2024
@garethgeorge garethgeorge merged commit 7a10bdc into main Apr 29, 2024
5 checks passed
@garethgeorge garethgeorge deleted the garethgeorge/task-cleanup branch April 29, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant