Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install.sh was calling systemctl on Darwin #260

Merged
merged 1 commit into from
May 2, 2024
Merged

fix: install.sh was calling systemctl on Darwin #260

merged 1 commit into from
May 2, 2024

Conversation

jancona
Copy link
Contributor

@jancona jancona commented May 2, 2024

In attempting to upgrade to 0.17.2 on MacOS, I noticed errors when running install.sh. It appears that the changes in be09303 broke the Darwin install. I restore the install_unix() function, which had be renamed, to contain the common code, and left the Linux-specific code in install_or_update_unix().

I haven't tested on Linux, but the change is small enough that I think I haven't broken anything.

@garethgeorge
Copy link
Owner

Ah, thanks for catching this! LGTM.

I'll also call out, incase it's convenient to you, there's now a brew tap for backrest https://github.com/garethgeorge/homebrew-backrest-tap which is hopefully a more robust way of keeping it up to date. I plan to support both this and the script install. Thanks for the fix!

@garethgeorge garethgeorge merged commit f6d5837 into garethgeorge:main May 2, 2024
@jancona
Copy link
Contributor Author

jancona commented May 2, 2024

Thanks. I actually noticed the Homebrew option right about when I finished fixing the install script. I switch to Homebrew right after I finished the PR.

@garethgeorge
Copy link
Owner

Hi, I'm evaluating relicensing Backrest as AGPL-3.0 . Thanks for contributing this fix!

I'm wondering if you'd be willing to retroactively sign a CLA? Or grant more specific permission to retain the copyright for your PRs but relicense your changes in the codebase under AGPL-3.0 .

I've become aware of a few SAAS looking at selling Backrest which goes philosophically against what I created it for (well they're welcome to -- but their platforms should be OSS and self-hostable re: the same freedoms Backrest provides!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants