Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building from dockerfiles / ghost processes #34

Closed
jvaughan opened this issue Jan 21, 2014 · 9 comments
Closed

Building from dockerfiles / ghost processes #34

jvaughan opened this issue Jan 21, 2014 · 9 comments

Comments

@jvaughan
Copy link

Hi,

Firstly, apologies if the following is obvious or if what I'm doing is just plain wrong. I'm quite to new to some of this stuff.

I am trying to, in one step: instantiate a vagrant box which, through puppet provisioning, builds several docker images from Dockerfiles and starts them.

I am experimenting with functionality for building images from Dockerfiles: jvaughan/garethr-docker@2e34bb2

However, it seems that docker::image is missing the requirement for docker::install, so was failing because of the lack of a docker executable to run.

I've tried adding

require docker::image

within the image class. This does satisfy the install dependency and means that the image gets built.

However, it seems to be triggering additional refreshes of the docker service, and this is causing my container to become ghosted in docker. The same ghosting occurs if I manually run

service docker restart

Do you have any suggestions of the best way to proceed?

BTW, if the 'build from dockerfile' functionality is considered useful, I will do a pull request once I have written some tests.

@dininski
Copy link

I'd say that the build from dockerfile functionality can be easily considered extremely useful. Consider the following scenario:
Using puppet to check if a docker manifest has changed. If it has been updated - rebuild the image (or build a new image).

@dininski
Copy link

Any new information on building a docker image for Dockerfile?

@hcguersoy
Copy link
Contributor

+1 - need it too.

@DracoBlue
Copy link

+1 me, too. Current workaround is to build the dockerfile and image somewhere else and push it to the target server afterwards.

@stefancocora
Copy link

+1
This would be quite a useful feature. It would bring to puppet the power that ansible has for now to build from Dockerfiles: http://docs.ansible.com/docker_image_module.html

@ghost
Copy link

ghost commented Aug 25, 2014

+1
Also please add docker import functionality.
If docker image is require we can build it or import from our repository.

@farion
Copy link

farion commented Oct 12, 2014

+1

@garethr
Copy link
Owner

garethr commented Oct 14, 2014

I've not had chance to look at this yet but if folks want to check out #131. I'm interested in feedback before accepting this.

@garethr
Copy link
Owner

garethr commented Dec 4, 2014

I've merged #131 which adds this functionality. The resource ordering issue has also recently been resolved. Thanks all.

@garethr garethr closed this as completed Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants