Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with node-serialport via bindings #40

Open
reconbot opened this issue Apr 7, 2016 · 8 comments
Open

Merge with node-serialport via bindings #40

reconbot opened this issue Apr 7, 2016 · 8 comments

Comments

@reconbot
Copy link

reconbot commented Apr 7, 2016

Hi Folks,
I'm working towards getting our c++ bindings isolated enough that we could switch out serialport implementations in an easier way. This could include the chrome serialport object. I think this is something to talk about because I'm going to be releasing some breaking changes to serialport to improve it's api and it's silly to implement everything twice. I'm thinking maybe we could merge projects.

I've opened serialport/node-serialport#739 to explore the option.

@garrows
Copy link
Owner

garrows commented Apr 7, 2016

Awesome idea @reconbot! Let me know if I can help.

@reconbot
Copy link
Author

reconbot commented Apr 8, 2016

yes! you very much can - I don't have a roadmap together yet, but the idea, is a minor bug release (With a major amount of bugs fixed), and then a major api change release, and then somewhere in there separating out and cleaning up the bindings. We could work chrome.serial in after the bug release I think.

@reconbot
Copy link
Author

So I've got 4.0 in release candidate status. We can either bring those changes here or work to merge sooner than later.

The upgrade guide talks about the changes directly.

reconbot added a commit to reconbot/firmata.js that referenced this issue Jun 17, 2016
To be used in testing. By the 4.0.0 release I hope to have browser serialport in parity.

SerialPort 4.0.0-rc1 is out and brings performance improvements, bug fixes and a few changes to the api. It's now out of sync with `browser-serialport` but not in a major way. garrows/browser-serialport#40

I suspect this upgrade won't have any far reaching effects as firmata uses only a fraction of the functions of SerialPort by default. The coms changes will be cleaner when browser serial port catches up.
reconbot added a commit to reconbot/firmata.js that referenced this issue Jun 17, 2016
To be used in testing. By the 4.0.0 release I hope to have browser serialport in parity.

SerialPort 4.0.0-rc1 is out and brings performance improvements, bug fixes and a few changes to the api. It's now out of sync with `browser-serialport` but not in a major way. garrows/browser-serialport#40

I suspect this upgrade won't have any far reaching effects as firmata uses only a fraction of the functions of SerialPort by default. The coms changes will be cleaner when browser serial port catches up.
@djipco
Copy link
Contributor

djipco commented Nov 2, 2016

This would also allow for future support of the proposed WebSerial API.

@weiway
Copy link

weiway commented Nov 3, 2016

It will be really nice to have a unified serial api for Javascript

@reconbot
Copy link
Author

reconbot commented Jan 15, 2017

I've almost completed a spike on a chrome bindings object. I'm a lost on how to use the tests with it, but I'm almost there.

https://github.com/EmergingTechnologyAdvisors/node-serialport/compare/web

@reconbot reconbot changed the title Explore merging with node-serialport Merge with node-serialport via bindings Jan 15, 2017
@reconbot
Copy link
Author

I just want to poke this issue, the aforementioned branch is way out of date. However SerialPort 5 is about to be released. A binding interface for this would now be pretty strait forward to make but hard to test in a CI.

The project as a whole is not something I can take on at this time. However if anyone wants to give it a try I'd be available to support their efforts!

@garrows
Copy link
Owner

garrows commented Jul 23, 2017

@reconbot thanks for the bump. I'm planning on reviving this repo next month and I'd love to do the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants