Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Clone Confirm Dialog Styling Issue #184

Closed
wangshijun opened this issue Apr 24, 2022 · 2 comments · Fixed by #185
Closed

[BUG] Clone Confirm Dialog Styling Issue #184

wangshijun opened this issue Apr 24, 2022 · 2 comments · Fixed by #185

Comments

@wangshijun
Copy link

The clone confirm dialog is weird, see screenshot below:

Screen Shot 2022-04-24 at 11 24 11

Steps to reproduce the behavior: the issue persists on every clone

The dialog should have a background, but it seems its transparent, env:

  • OS: Mac
  • Browser: chrome
  • Version: 0.3.0

I installed a bunch of GitHub extensions from the web store, maybe the bug is caused by that?

@johnmurphy01
Copy link
Contributor

@wangshijun yes, looks like Github may have changed their CSS classes again. The code will need to be updated to account for this

@johnmurphy01
Copy link
Contributor

These are the new CSS variables:

    --color-workflow-card-connector: var(--color-scale-gray-5);
    --color-workflow-card-connector-bg: var(--color-scale-gray-5);
    --color-workflow-card-connector-inactive: var(--color-border-default);
    --color-workflow-card-connector-inactive-bg: var(--color-border-default);
    --color-workflow-card-connector-highlight: var(--color-scale-blue-5);
    --color-workflow-card-connector-highlight-bg: var(--color-scale-blue-5);
    --color-workflow-card-bg: var(--color-scale-gray-7);
    --color-workflow-card-inactive-bg: var(--color-canvas-inset);
    --color-workflow-card-header-shadow: rgba(27, 31, 35, 0.04);
    --color-workflow-card-progress-complete-bg: var(--color-scale-blue-5);
    --color-workflow-card-progress-incomplete-bg: var(--color-scale-gray-6);
    --color-discussions-state-answered-icon: var(--color-scale-green-3);
    --color-bg-discussions-row-emoji-box: var(--color-scale-gray-6);
    --color-notifications-button-text: var(--color-scale-white);
    --color-notifications-button-hover-text: var(--color-scale-white);
    --color-notifications-button-hover-bg: var(--color-scale-blue-4);
    --color-notifications-row-read-bg: var(--color-canvas-default);
    --color-notifications-row-bg: var(--color-canvas-subtle);
    --color-icon-directory: var(--color-fg-muted);
    --color-checks-step-error-icon: var(--color-scale-red-4);
    --color-calendar-halloween-graph-day-L1-bg: #631c03;
    --color-calendar-halloween-graph-day-L2-bg: #bd561d;
    --color-calendar-halloween-graph-day-L3-bg: #fa7a18;
    --color-calendar-halloween-graph-day-L4-bg: #fddf68;
    --color-calendar-graph-day-bg: var(--color-scale-gray-8);
    --color-calendar-graph-day-border: rgba(27, 31, 35, 0.06);
    --color-calendar-graph-day-L1-bg: #0e4429;
    --color-calendar-graph-day-L2-bg: #006d32;
    --color-calendar-graph-day-L3-bg: #26a641;
    --color-calendar-graph-day-L4-bg: #39d353;
    --color-calendar-graph-day-L1-border: rgba(255, 255, 255, 0.05);
    --color-calendar-graph-day-L2-border: rgba(255, 255, 255, 0.05);
    --color-calendar-graph-day-L3-border: rgba(255, 255, 255, 0.05);
    --color-calendar-graph-day-L4-border: rgba(255, 255, 255, 0.05);
    --color-user-mention-fg: var(--color-scale-yellow-0);
    --color-user-mention-bg: var(--color-scale-yellow-8);
    --color-text-white: var(--color-scale-white);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants