Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Extension's styles break layout for "Checks..." section on pull requests #202

Closed
patrickhlauke opened this issue Jun 19, 2024 · 5 comments · Fixed by #209
Closed
Assignees

Comments

@patrickhlauke
Copy link

patrickhlauke commented Jun 19, 2024

Describe the bug

When the extension is installed/enabled, items in the "Checks..." section on pull requests break out of their container box.

Screenshot showing a failing 'Check', with its item overflowing the overall 'Checks' container left and right

Disabling the extension and reloading, the problem goes away, so it's definitely related to whatever styles this extension injects.

Screenshot of the same section, now with the correct layout

PR used to test this: w3c/wcag#3909 (though it'll likely be merged and closed by the time this gets looked at)

To Reproduce
Steps to reproduce the behavior:

  1. Go to a pull request with checks with the extension enabled - observe the problem with layout
  2. Disable the extension
  3. Reload the page - notice the layout problem is gone

Expected behavior

The styles should not break the layout of the "Checks..." section.

Screenshots
See above

Desktop (please complete the following information):

  • OS: Windows and macOS
  • Browser: Chrome
  • Version: Latest
@johnmurphy01
Copy link
Contributor

@all-contributors please add @patrickhlauke for bugs

Copy link
Contributor

@johnmurphy01

I've put up a pull request to add @patrickhlauke! 🎉

@johnmurphy01
Copy link
Contributor

@patrickhlauke thanks! I verified you bug report. It looks like I'm indeed using a open class and setting the display to inline. GitHub also uses a open class but they aren't putting any CSS styling into it. So I should be able to scope my CSS so that it doesn't affect other parts of the page.

@patrickhlauke
Copy link
Author

lovely, thank you

@johnmurphy01
Copy link
Contributor

@patrickhlauke I've submitted a new version of Kamino (4.0.1). Once it's approved by the web store, it should be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants