Inject button/modal in new issue/PR experience structure #218
Conversation
Makes the extension also work in the new (currently in Beta) issue/PR experience that users can opt into at the moment.
|
Note that I was not able to properly test this - whenever I try to just run this locally from directory, I get extension errors due to the |
|
To test, make sure to enroll in the "Beta" experience (at the top of an /issues page)
|
I'll add a Testing section to the README. But the module errors should not prevent the extension from being used. I tested last week and those errors were present. I think Chrome extensions don't like ES6 notation but I'm using that in order to run some Jest tests |
Hmm I'm not seeing that prompt. I guess maybe it's only available to some people? |
|
it may indeed be the case that only certain cohorts have had the beta enabled for them. have a look if you have the "Feature preview" option in the user menu, and then "Issue vNext" there
|
patrickhlauke
force-pushed
the
patrickhlauke-new-issue-pr-experience
branch
2 times, most recently
from
debdeb4
to
d716fad
Compare
Original selector was stupidly incorrect. Also, as we're now inserting *after*, need to reverse the order in which we insert these, otherwise the modal will come before the button
patrickhlauke
force-pushed
the
patrickhlauke-new-issue-pr-experience
branch
from
d716fad
to
dd2de65
Compare
just in case GH decide to use same/similar classname
|
After some tweaking (i did end up having the wrong selector), managed to get this working for the most part for local testing. The last outstanding issue I'm seeing is that the dropdown doesn't automatically close / the page doesn't reload after I choose an option in the modal...and I'm not sure where to look for the cause just yet. this may be down to the fact that the new issue experience uses React, while the previous one was Rails, so ... might not do an actual page reload/refresh of parts when things change? kamino-new-issue-experience.mp4 |
|
@patrickhlauke let me see if I can get in contact with someone at Github to enroll in the beta. I can help troubleshoot. But can you check the network traffic after you choose a repo? It should be making github api calls, maybe one of them is failing or timing out? Although it does appear that it worked after a refresh |
Makes the extension also work in the new (currently in Beta) issue/PR experience that users can opt into at the moment.