Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Showcase permalink error #10727

Closed
shannonbux opened this issue Dec 30, 2018 · 9 comments
Closed

Site Showcase permalink error #10727

shannonbux opened this issue Dec 30, 2018 · 9 comments
Labels
stale? Issue that may be closed soon due to the original author not responding any more. type: bug An issue or pull request relating to a bug in Gatsby

Comments

@shannonbux
Copy link
Contributor

Description

The last several times I've clicked on "visit a site" from a site detail page and then, after browsing the site, use the back arrow to try and go back to the site showcase, there is just a blank white page staring at me!

Steps to reproduce

  1. Go to gatsbyjs.org/showcase
  2. Click on any site
  3. Click on "visit site" button
  4. Once the site loads, click on back arrow

Voila, there is probably a white page.

Expected result

You should see the detail page of the site that you just visited.
For example: https://www.gatsbyjs.org/showcase/www.howtographql.com (actually, @fk is this the correct URL I should expect for a permalink?)

Actual result

A blank white page. Here's the console errors:

screen shot 2018-12-29 at 9 33 15 pm

Environment

Chrome browser

@jgierer12
Copy link
Contributor

I can reproduce this in Chrome, but not Firefox.

@jgierer12 jgierer12 added the type: bug An issue or pull request relating to a bug in Gatsby label Dec 30, 2018
@sidharthachatterjee
Copy link
Contributor

Breaks on public-page-renderer-prod.js because pageResources is undefined

@pieh Related to ensure resources?

@sidharthachatterjee
Copy link
Contributor

This only occurs when visiting a site via the modal, normal page works fine.

@pieh mentioned that we need to put we put shouldShowModal in history

Still strange that it works on Firefox though

@pieh
Copy link
Contributor

pieh commented Dec 31, 2018

Also for reference: #7501

Using directly has the caveat that you can't use it
unless the page resources are already loaded. [...] Otherwise it'll break.

which is exact scenario that is happening here

@sidharthachatterjee
Copy link
Contributor

Firefox seems to be doing some magic by persisting a snapshot of the page and using that when one hits the back button. Refreshing on Firefox also causes this issue.

@pieh
Copy link
Contributor

pieh commented Dec 31, 2018

We have couple of possibilities here:

  • wrap public PageRenderer in EnsureResources - we might hit same problems we hit before with react constantly updating and re-rendering that wasn't really figured out - need to research that.
  • add check if resources exist in public PageRenderer and return null if we don't have resources - also would need to adjust www code to fallback to non-modal version of showcase details page if background page would be null

@laradevitt
Copy link
Contributor

Just came across this. Some additional info, FWIW...

Can also replicate in Edge 42.17. Refreshing the page in Edge will load it normally. In Chrome (71.0.35) it does not; the error persists.

To reliably replicate the problem in Edge I need to restart the browser; in Chrome I just need a new incognito window.

Also: if I start on a Showcase site page (e.g., https://www.gatsbyjs.org/showcase/airbnb.io) there is no issue. I could only replicate it by first going to https://www.gatsbyjs.org/showcase.

@gatsbot
Copy link

gatsbot bot commented Feb 14, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 14, 2019
@gatsbot
Copy link

gatsbot bot commented Feb 25, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

Thanks again for being part of the Gatsby community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more. type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

No branches or pull requests

5 participants