-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-remark-images): handle image references #11086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great. Would you be able to add any tests and/or snapshots to validate this functionality?
@DSchau have added in some test and snapshots to validate the following
|
is this ok to merge? |
I've added passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this in. We can potentially iterate on implementation in future, there's no reason not to merge and publish.
Thanks @artbycrunk!
Holy buckets, @artbycrunk — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Description
Hey guys this is a fix for gatsby-remark-images to pickup and process imageReference nodes correctly.
enabling the following syntax
Related Issues
Fixes #11085