feat(gatsby-plugin-manifest): make favicon link tag optional #11414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidharthachatterjee
previously requested changes
Jan 30, 2019
sidharthachatterjee
added
the
status: blocked
wardpeet
suggested changes
Jan 31, 2019
Co-Authored-By: gurpreet-hanjra <[email protected]>
Co-Authored-By: gurpreet-hanjra <[email protected]>
|
@wardpeet @sidharthachatterjee review comments are fixed. Please review. |
wardpeet
approved these changes
Jan 31, 2019
wardpeet
dismissed
sidharthachatterjee’s stale review
Everything is resolved :)
wardpeet
removed
the
status: blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue - #11308
Description
Makes favicon link tag optional using plugin option
include_faviconRelated Issues