fix(gatsby-remark-images): remove clickable whitespace around image when linking

[ajschmidt8]

This PR changes the way that gatsby-remark-images handles linking image thumbnails to their originals.

Behavior Before PR

Currently, the a tag that links to the original image expands to fill the entire parent.

Behavior After PR

The new behavior makes the link only contain the image and not any extra whitespace.

The Jest snapshots for this package were updated to reflect this change.

[ajschmidt8]

@pieh, @DSchau, is there anything I can do to get this reviewed/merged quickly?

[DSchau]

@ajschmidt8 can you allow permission to push to your branch?

https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

To github.com:ajschmidt8/gatsby.git
 ! [remote rejected]     topics/fix-remark-images -> topics/fix-remark-images (permission denied)
error: failed to push some refs to '[email protected]:ajschmidt8/gatsby.git'

[ajschmidt8]

@DSchau, done!

[DSchau]

Is the general idea here that we don't want the extra space surrounding the image to be clickable?

I'm not really sure which behavior is preferable--could you provide why it's advantageous one way or the other?

[ajschmidt8]

Is the general idea here that we don't want the extra space surrounding the image to be clickable?

I'm not really sure which behavior is preferable--could you provide why it's advantageous one way or the other?

@DSchau yes, that is the idea. The screenshots above are from a page on a site that I'm building. As indicated in the pictures, if you click in the whitespace surrounding the image, it will open the original image in a new URL. I found this to be kind of an annoyance. I thought it would be better if the original image only opened when the actual thumbnail was clicked and not the surrounding whitespace.

[ajschmidt8]

It seems like it would be misleading to users if they clicked whitespace and an image popped up.

[ajschmidt8]

@DSchau, just pulled the latest and fixed some merge conflicts. let me know if this can be merged soon 😬

[freiksenet]

@ajschmidt8 Could you allow me to push to your repo so that I can merge the conflicts?

[ajschmidt8]

@freiksenet i just resolved the conflicts and pushed the changes 👍

[freiksenet]

Sorry for the delay! Thank you for working on this.

[gatsbot]

Holy buckets, @ajschmidt8 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

[wardpeet]

Published in [email protected]