Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] Potential renaming of remark-responsive-image plugin #1286

Closed
chiedo opened this issue Jun 28, 2017 · 4 comments
Closed

[1.0] Potential renaming of remark-responsive-image plugin #1286

chiedo opened this issue Jun 28, 2017 · 4 comments

Comments

@chiedo
Copy link

chiedo commented Jun 28, 2017

I'm wondering if a better name for gatsby-remark-responsive-image would be gatsby-remark-build-images

My thinking is that the current name is a little misleading and the intent isn't clear. If I don't want images to be responsive, I may ignore that package all together not realizing that it's necessary to get my images from my markdown files so that they work in my build.

If we did change the name, then the default could be to just copy the default version of the image without creating all the responsive versions and we could have a responsive option that when set to true would do what it does now.

Just a thought. If it isn't helpful, feel free to ignore. :)

@KyleAMathews
Copy link
Contributor

Hmmm that is a better name. You want to submit a PR? I can then deprecate the old package on NPM.

Keep the functionality the same though. Creating responsive versions should always be the default. If someone really cares enough to make an option for just copying images over then we could take a PR for that or they could make their own plugin.

@chiedo
Copy link
Author

chiedo commented Jun 28, 2017

Deal!

I will submit the PR.

Thanks for being cool with new ideas.

@chiedo
Copy link
Author

chiedo commented Jun 28, 2017

PR submitted! #1288

@KyleAMathews
Copy link
Contributor

Fixed in #1288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants