Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of results on dev 404 page and add search #13204

Closed
KyleAMathews opened this issue Apr 8, 2019 · 2 comments · Fixed by #13344
Closed

Limit number of results on dev 404 page and add search #13204

KyleAMathews opened this issue Apr 8, 2019 · 2 comments · Fixed by #13344
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with.

Comments

@KyleAMathews
Copy link
Contributor

It can get expensive (and useless) to render all site pages on the dev 404 page. Instead we should show a subset of pages (once past e.g. 100 pages) and add a simple search

See discussion @ #13186 (comment)

@KyleAMathews KyleAMathews added good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with. labels Apr 8, 2019
@me4502
Copy link
Contributor

me4502 commented Apr 9, 2019

@bennetthardwick and I have discussed this issue a fair bit, as the site we are working on is at 60k pages at the moment.

One thing we've thought of is having a tree-like structure that you can expand and contract. Eg, if you had a page structure such as /animals/cats, /animals/cats/ragdoll, /animals/dogs, /animals/birds, and then /foods/cat-food, you could expand the animals section to show cats, dogs, and birds, then expand cats to show ragdoll.

I do agree a glob based search could be very useful as well.

@KyleAMathews
Copy link
Contributor Author

Tree structure would be fun too! Feel free to out up a PR. This is a very simple page right now and obviously broken for large sites so let's do something at least incrementally better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants