-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs site] Webassembly Error When Building #13641
Comments
After searching around for this error message, it seems like this issue is possibly related, something related to interactions between React Hooks and the React Hot Loader. |
I am also seeing this error in a private Gatsby project. It looks like this release is the culprit: 25a36d3. |
I've updated my Gatsby project to [email protected], but I still get the same error. |
@IvanKovnovic 2.3.31 is the release that caused this to break. Rollback to 2.3.30 or earlier until a fix for this is released. |
For anyone who comes here after me, I rolled back Gatsby to 2.3.30 and still see the same error. I had to rollback to 2.3.29 npm install [email protected] |
@jsjoeio are you sure about that? 2.3.31 is the version that introduced the change that causes this error, so I can't see why 2.3.30 would be effected by this. Did you ensure that you actually had 2.3.30 installed locally? |
@joealden to give you some context, I was trying to help a friend with this issue. I cloned his repo and was having problems running So the answer is, I'm not sure. My intention behind commenting on this was to help anyone else who couldn't fix it by rolling back to 2.3.30. |
@jsjoeio if I came off a bit abrasive in my above comment, I didn't mean to, so sorry if I did. I was only commenting as I didn't see how the issue would still exist when having 2.3.30 installed. I've have since tested it locally and can say with a high degree of confidence that 2.3.30 doesn't cause this error, so I think you must have accidentally still had 2.3.31 installed without realising it. I'm clarifying this so the devs know exactly what caused this issue, and can potentially solve it more efficiently. |
@joealden no worries at all! I know you were just trying to clarify. Glad you made that point. I think you're right right about that. I must have still been using 2.3.31. Hoping all of this contributes to us solving it as a community! |
Rolling back the commit, sorry about this. I make sure to have a proper test case in place and try to fix hmr with hooks in a newer PR. |
[email protected] should fix your issues. We rolled back the PR that caused this. Sorry for the inconveniences it may have caused. |
@wardpeet this rollback fixed the issue. I think this issue is safe to close for now. |
Do you mind testing #13713 or if possible share your repo so we can test the PR ourselves and see if we actually fixed the issue so we don't break it again. |
@wardpeet unfortunately the repo that it is failing on for me is a private work related project, so I can't really give you access to it. When I get some free time today, I'll test this PR with this repo myself. |
Thanks that's super valuable feedback! Let me close this one out. Thanks again! 🎉 |
@wardpeet no problem! Looking forward to this PR being merged! Also, something I forgot to mention, I read the PR description and saw that you mentioned the underlying issue was with a |
I am adding prismic sourcing and get this issue. |
Description
Documentation site was unable to build locally, encountered while trying to test #13640
Steps to reproduce
Following the directions in the docs contributions page
Expected result
Build completes without error
Actual result
Environment
The text was updated successfully, but these errors were encountered: