fix(gatsby-remark-images): captions do not show fallback based on filename #14219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
changed the title
DSchau
reviewed
May 21, 2019
There was a problem hiding this comment.
First of all--thanks for doing this!
Few things:
- How about a test to validate the functionality? e.g. creating empty alt text with an image and validating that a caption does not appear?
- You had a lint error, I've queued up a job to fix it right up. You may need to pull from your branch, e.g.
git pull origin caption-issues
before making any changes!
|
Had a chance to fix the linting issues. Will do a test a bit later! |
|
@DSchau Added a test! EDIT: Seems that there's an issue with the jest snapshot? Is it Windows related or something maybe? |
|
@DSchau I just reverted the change to the snapshot - Seems to be working fine now! |
DSchau
suggested changes
May 22, 2019
|
There you go! |
DSchau
approved these changes
May 23, 2019
|
Successfully published: |
weakish
added a commit
to weakish/site
that referenced
this pull request
May 27, 2019
gatsby-remark-images 3.0.11 (introduced in 7de7ad4) will show alt as caption if no caption is provided, and filename as caption if no alt/caption is provided. gatsbyjs/gatsby#14219 fixed the fallback to filename issue, but still preserves the fallback to alt behaviour. Thus I set showCaptions to false. (`alt` is intended for users cannot see the image. Displaying *alternative* text *alongside* images feels wierd.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where captions would show the image filename if no caption/alt was given.
Related Issues
Fixes #14188